Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add renovate #5238

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add renovate #5238

wants to merge 1 commit into from

Conversation

PrashantR30
Copy link

Description

Adding Renovate so to automate the checks and updates packages dependencies in the embedded-bins/Makefiles.variables

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Manual test
  • Auto test added

The version of the packages version were modified to an earlier version and renovate was run https://github.com/PrashantR30/go_app_3/pulls and we could see the checks were done and PR created for new versions of the depencencies

Checklist:

  • My code follows the style guidelines of this project
  • My commit messages are signed-off
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@PrashantR30 PrashantR30 requested review from a team as code owners November 13, 2024 04:21
@twz123
Copy link
Member

twz123 commented Nov 13, 2024 •
edited
Loading

Thanks for looking into this! Unfortunately, it's not that easy to generate proper version bumps for most of the stuff in the Makefiles. I'd like to start with something really simple first, and then add more and more stuff to it. How about starting with just Alpine (as I think this is the only one that can be done by solely incrementing stuff in the Makefile), so that we have the skeleton and a simple example, and then add other stuff to it in individual PRs? I imagine that we need to restructure things a bit on a case by case basis for automatic version bumps to be working reliably.

@PrashantR30
Copy link
Author

Thanks @twz123, I'll update the PR to focus on Renovate on-boarding and Alpine only. Once that's in place, we can add other dependencies gradually in separate PRs. Appreciate the guidance!

@PrashantR30 PrashantR30 reopened this Nov 14, 2024
@twz123 twz123 added enhancement New feature or request and removed chore labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makhov makhov Awaiting requested review from makhov makhov is a code owner automatically assigned from k0sproject/k0s-maintainers

@twz123 twz123 Awaiting requested review from twz123 twz123 is a code owner automatically assigned from k0sproject/k0s-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area/ci enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PrashantR30 @twz123